search

elixir-mongo / mongodb

MongoDB driver for Elixir
Apache License 2.0
571 stars 156 forks source link

Clear warning #325

Closed pierreabreup closed 4 years ago

pierreabreup commented 4 years ago 
==> mongodb
Compiling 34 files (.ex)
warning: variable "cursor" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/mongo/protocol.ex:177: Mongo.Protocol.handle_deallocate/4

warning: variable "opts" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/mongo/protocol.ex:177: Mongo.Protocol.handle_deallocate/4

warning: variable "query" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/mongo/protocol.ex:177: Mongo.Protocol.handle_deallocate/4

warning: variable "opts" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/mongo/protocol.ex:184: Mongo.Protocol.handle_declare/4

warning: variable "params" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/mongo/protocol.ex:184: Mongo.Protocol.handle_declare/4

warning: variable "cursor" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/mongo/protocol.ex:232: Mongo.Protocol.handle_fetch/4

warning: variable "opts" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/mongo/protocol.ex:232: Mongo.Protocol.handle_fetch/4

warning: variable "query" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/mongo/protocol.ex:232: Mongo.Protocol.handle_fetch/4

warning: variable "opts" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/mongo/protocol.ex:239: Mongo.Protocol.handle_prepare/3

warning: variable "opts" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/mongo/protocol.ex:246: Mongo.Protocol.handle_rollback/2

warning: variable "opts" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/mongo/protocol.ex:253: Mongo.Protocol.handle_status/2

warning: function get_last_error/1 is unused
  lib/mongo.ex:1058

warning: function index_map/3 is unused
  lib/mongo.ex:1113

warning: function singly_cursor/5 is unused
  lib/mongo.ex:985

Generated mongodb app
ankhers commented 4 years ago

Would you be willing to put together a PR for this?

pierreabreup commented 4 years ago

Yes, sure!! 💃

I will do it in my weekend. Is it ok for you?

ankhers commented 4 years ago

That sounds great!

numso commented 4 years ago

Looks like this has already been fixed in master (https://github.com/ankhers/mongodb/pull/291). @ankhers Any chance we could get a new version published? Or is the next version waiting on more changes that we could help with?

ankhers commented 4 years ago

Closing because of #291.

@numso I will go through what has changed and see if it is worth making a release soon.