[in-progress] Add credo to project for better code-readability and performance fixes

elixir-nx / bumblebee

Pre-trained Neural Network models in Axon (+ 🤗 Models integration)

Apache License 2.0

1.27k stars 90 forks source link

Closed imahmedismail closed 7 months ago

imahmedismail commented 7 months ago

This PR includes the following major changes:

Add credo 1.7 to elixir-nx/bumblebee
Fix the code-readability issues in the project:
- Numbers larger than 9999 should be written with underscores: 38_576
- Do not use parentheses when defining a function which has no arguments.
- The alias is not alphabetically ordered among its group.
- Skip Credo.Check.Readability.PreferImplicitTry to fix Prefer using an implicit 'try' rather than explicit 'try'.

imahmedismail commented 7 months ago

THIS PR IS STILL IN PROGRESS Still need to resolve these issues pointed-out by credo:

josevalim commented 7 months ago

We have no plan to adopt Credo or others linters in Nx projects. Thank you!

imahmedismail commented 7 months ago

Okay thanks for quick-response @josevalim