elixir-nx / hnswlib

Elixir binding for the hnswlib library.
Apache License 2.0
52 stars 9 forks source link

lower required glibcxx version #11

Closed cocoa-xu closed 9 months ago

cocoa-xu commented 11 months ago

Links to #9

josevalim commented 11 months ago

Thank you @cocoa-xu! Let's give compiling with 20.04 a try and, if people still run into issue, having this as reference will be very helpful. :)

cocoa-xu commented 11 months ago

Yeah I was near there but it seems that we still have some weird floating-point issues with ppc64le, as well as some issue with the qemu-aarch64-static emulator that would cause a segementation fault when doing mix local.hex --force.

cocoa-xu commented 9 months ago

Hi @josevalim, I decided to only compile x86_64, i686 and s390 on manylinux2014 while keeping the rest of Linux targets compiled on ubuntu-20.04. Doing so should lower the required glibcxx version to 2.14 for x86_64, i686 and s390.

Moreover, as I believe most users are using x86_64-linux-gnu, lowering the glibcxx version should address the issue for users who have to work with some old versions of Linux.

josevalim commented 9 months ago

Sounds good to me, as you prefer!