elixir-nx / hnswlib

Elixir binding for the hnswlib library.
Apache License 2.0
52 stars 9 forks source link

Clean up the priv directory between different targets #14

Closed cocoa-xu closed 9 months ago

cocoa-xu commented 9 months ago

This PR should close #13 by setting the cleanup key for cc_precompile so that the private directory of this library gets cleaned up between different targets. Otherwise, it would result in archiving the same shared library file for all build targets:

Screenshot 2023-11-21 at 13 52 37
josevalim commented 9 months ago

Good call! We can likely merge this and do a new release with #11!

cocoa-xu commented 9 months ago

Good call! We can likely merge this and do a new release with #11!

Yeah, sure! I'm going to fix the issue with Windows CI first, and we can do a new release!

cocoa-xu commented 9 months ago

Finally, CI all green!