search

elixir-nx / nx

Multi-dimensional arrays (tensors) and numerical definitions for Elixir
2.66k stars 194 forks source link

fix: exla rpath #1553

Closed polvalente closed 3 weeks ago

polvalente commented 3 weeks ago

There's some weird interplay between how EXLA looks up the rpath if it's the main app or if it's a library. Just copying over the unversioned cache .so seems to be the simplest solution.

This probably doesn't solve the problem of dealing with a stale libexla.so, but the new env var, even in partial mode, will deal with rebuilding everything for a new version

josevalim commented 3 weeks ago

Maybe we keep the .o versioned and not the final one. This should be enough for make to trigger a rebuild whenever the version changes.

polvalente commented 3 weeks ago

There is an issue here in that the .so can be huge, back then it was 300MB, so duplicating that in disk can be too much. I checked and it was like 2MB or something.

I'll keep libexla.so unversioned for simplicity then. The main problem was stale intermediate .o, and that's already solved