More flexible rustler dependency

elixir-nx / ortex

ONNX Runtime bindings for Elixir

MIT License

122 stars 15 forks source link

More flexible rustler dependency #33

Closed mwhitworth closed 2 months ago

mwhitworth commented 3 months ago

The current dependency for rustler is ~> 0.29.0 - allowing this to vary over more minor versions and making appropriate changes to functions based on the exact rustler version installed would be as flexible as possible with other libraries using rustler that an application may have installed.

(I'll look into this and submit a PR)

mortont commented 3 months ago

Agreed, it should be safe to make that dependency ~> 0.29 instead. I'm not sure if we can loosen it up any more than that though. Happy to review a PR, thanks!

mwhitworth commented 2 months ago

I loosened it to ~> 0.27 and made some conditional compilation changes in #35 - tests passed for all minor versions up to and including 0.33.0.