search

elixir-nx / scidata

Download and normalize datasets related to science
Apache License 2.0
164 stars 13 forks source link

Use CA Store from Hex or OS? #41

Open marcnnn opened 10 months ago

marcnnn commented 10 months ago

Hello

Thanks for providing this package!

I am new Elixir and kind of confused that you download a CA bundle in such a high level package.

Is it possible to use the one Hex is using? Or the one provided by the operating system?

https://github.com/elixir-nx/scidata/blob/ea7a4883464584530b6a49f95b0eea2f5b954b80/lib/scidata/utils.ex#L40

josevalim commented 10 months ago

Erlang/OTP 25+ does come with access to OS certificates, so once we require said Erlang version, we won't need the additional CA bundle. For earlier versions, having a separate store is the simplest. I will leave this open so we don't forget to eventually tackle this. Thank you!