search

elixir-nx / xla

Pre-compiled XLA extension
Apache License 2.0
83 stars 21 forks source link

fix: make build for metal work #51

Closed polvalente closed 10 months ago

polvalente commented 10 months ago

Still needs validation for CUDA and CPU builds

josevalim commented 10 months ago

Shall we include the metal plugin so no additional downloads are required on EXLA side?

polvalente commented 10 months ago

It seems to be closed source, so I'm not exactly sure how to go about that...

josevalim commented 10 months ago

Gah, now I am getting cold feet too. If using metal means we cannot upgrade XLA until there is a new metal version and that we need to package closed source code, then perhaps it is not worth doing it until Apple decides to provide an open source version that does not pin jaxlib/xla.

jonatanklosko commented 10 months ago

If using metal means we cannot upgrade XLA until there is a new metal version

I definitely agree, I would at least wait with releasing the integration until the metal plugin is updated to latest jaxlib. But if it stays closed source and pinned then committing to maintaining the compatibility may hold as back, so it is tough.

polvalente commented 10 months ago

Let's close this for now. We'll work on the MLIR EXLA compiler regardless