search

elixir-plug / plug

Compose web applications with functions
https://hex.pm/packages/plug
Other
2.88k stars 586 forks source link

Add support telemetry v1.0 #1041

Closed wingyplus closed 3 years ago

whatyouhide commented 3 years ago

This was already addressed in https://github.com/elixir-plug/plug/commit/8c62513ac0ed0b0c19991f9c5c6a9635ed905e72#diff-dfa6f4ed74c90e5d4fda283d547d366586e690387289bcfd473e3fa5f9ace308. Thanks @wingyplus! 💟

wingyplus commented 3 years ago

@whatyouhide That's great. Do we needs to strict to ~> 0.4.2 or ~> 0.4.3? because the library use :telemetry.span since it's introduces in 0.4.2. Or do I misunderstand something?

josevalim commented 3 years ago

Good call, fixed in master.

wingyplus commented 3 years ago

@josevalim Thank you. 😊