elixir-plug / plug

Compose web applications with functions
https://hex.pm/packages/plug
Other
2.88k stars 586 forks source link

Increase of compile-connected through xref #1086

Closed raphaklaus closed 2 years ago

raphaklaus commented 2 years ago

Hello!

I noticed that after upgrading from 1.13.4 to 1.13.5 it shows an extra compile-connected dependency:

lib/plug_compile_connected_issue_web/endpoint.ex
└── lib/plug_compile_connected_issue_web/router.ex (compile)

Demo repo (created with phx.new): https://github.com/raphaklaus/plug_compile_connected_issue

The master branch is pointing to version 1.13.4, which doesn't happen when running mix xref graph --label compile-connected

The branch named 1.13.5 shows the reported above.

This commit 04ac60af08d206c81073ca62dc7a7cf15542be42 seems to talk about an init_mode that can be set to :compile or :runtime, but I am not sure if using that (if I used correctly) will fix the issue.

josevalim commented 2 years ago

Fixed on v1.13.6!