search

elixir-plug / plug

Compose web applications with functions
https://hex.pm/packages/plug
Other
2.84k stars 582 forks source link

Fix Plug.Conn.Status.reason_phrase/1 error message #1131

Closed jclem closed 1 year ago

jclem commented 1 year ago

When Plug.Conn.Status.reason_phrase/1 is called with an error code not defined by Plug or via configuration, the message of the ArgumentError that's raised references the atom :unavailable_for_legal_reasons. According to the example code above and below the text, it should instead reference :not_an_rfc_status_code.

Here's hoping HTTP 998 Not An RFC Status Code is never proposed 😆

I hope this typo PR isn't too noisy—it seems worthwhile to correct the confusing error message.

josevalim commented 1 year ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart: