Adapters removed in 1.4.1 without deprecation warnings

elixir-plug / plug

Compose web applications with functions

https://hex.pm/packages/plug

Other

2.84k stars 582 forks source link

Adapters removed in 1.4.1 without deprecation warnings #1138

Closed Ch4s3 closed 1 year ago

Ch4s3 commented 1 year ago

I'm seeing some libraries breaking in an attempt to upgrade to 1.41 since this change was introduced that removed Plug.Adapters.Cowboy. The change makes sense, but looking back ad my CI logs I don't see any deprecation warnings about this coming from plug 1.4.0. I'm not sure what would be the right thing to do here, but this definitely makes the upgrade path a bit harder since we now need to go an submit PRs in places like fun_with_flags_ui.

josevalim commented 1 year ago

You are right. I will revert and push a new version. They were not warning.

Ch4s3 commented 1 year ago

Oh wow, thanks for the quick reply @josevalim!

josevalim commented 1 year ago

1.14.2 out.

Ch4s3 commented 1 year ago

Thanks José!