elixir-plug / plug

Compose web applications with functions
https://hex.pm/packages/plug
Other
2.81k stars 578 forks source link

Plug builder documentation edits (lib/plug/builder.ex) #1189

Closed bradhanks closed 8 months ago

bradhanks commented 8 months ago

lib/plug/builder.ex

removed passive voice, attempted to add clarity

bradhanks commented 8 months ago

I added a refactored test to remove the following warning:

warning: Plug.Conn.Query.decode_pair/2 is deprecated. Use decode_init/0, decode_each/2, and decode_done/2 instead Warning: test/plug/conn/query_test.exs:184: Plug.Conn.QueryTest.decode_pair/1

josevalim commented 8 months ago

The deprecation is there on purpose. It is testing the old deprecated API still works. :) we already have tests for the new code. Thanks!