Extend receive to fix flaky drainer test

elixir-plug / plug_cowboy

Plug adapter for the Cowboy web server

Other

243 stars 48 forks source link

Closed binaryseed closed 3 years ago

binaryseed commented 3 years ago

I'm hoping that we can work towards the next release, so I'm seeing if this will clear up the test that's been failing in the last few builds

binaryseed commented 3 years ago

I am guessing the switch over to Github Actions just changed the execution speed of the tests or something

@josevalim

josevalim commented 3 years ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:

josevalim commented 3 years ago

That didn't seem to have fixed it. :( It seems the issue happens on 23+ only but I cannot reproduce it locally.

binaryseed commented 3 years ago

Dang, I was hoping the green PR build was real... I saw the failure just a single time locally the first time I ran that test, but it never repeated.