search

elixir-plug / plug_cowboy

Plug adapter for the Cowboy web server
Other
243 stars 48 forks source link

Longer 'slow' process #53

Closed binaryseed closed 3 years ago

binaryseed commented 3 years ago

Followup to #51

A different theory.. perhaps the timing race is around this "slow" process & the the wait on the number of connections in observe_state_changes

binaryseed commented 3 years ago

I don't have access but perhaps we can trigger this to run a handful of times?

josevalim commented 3 years ago

I ran 3x times and they all passed, good job! :D Do you want me to release 2.4.0?

josevalim commented 3 years ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:

binaryseed commented 3 years ago

Yeah, I say we should do a release.. I've built out an integration with the cowboy_telemetry events and it works exactly as expected!

In the past you mentioned going to 3.0 because of the telemetry events situation, but to be honest, I'd be fine with a 2.4 since it's pretty likely that most apps have ~> 2.0 in their mix.exs and adoption is going to be much slower if we go 3. What do you think?