search

elixir-plug / plug_cowboy

Plug adapter for the Cowboy web server
Other
243 stars 48 forks source link

Add 1.13 to CI matrix #81

Closed fastjames closed 2 years ago

fastjames commented 2 years ago

In order to keep up with newer elixir / OTP versions, add 1.13 to the test matrix (and a few dependency updates to make the new version pass).

Closes https://github.com/elixir-plug/plug_cowboy/issues/80 .

josevalim commented 2 years ago

It may be that updating some dependencies will make earlier Erlang/OTP versions crash.

fastjames commented 2 years ago

It may be that updating some dependencies will make earlier Erlang/OTP versions crash.

The CI failure supports your hypothesis. :-D I will see if I can find a balance point where all the versions can coexist.

josevalim commented 2 years ago

Bumping OTP version on Elixir 1.7 may be enough. 21 or 22.

fastjames commented 2 years ago

Bumping OTP version on Elixir 1.7 may be enough. 21 or 22.

Thanks for the suggestion -- it worked in my local testing, so I pushed a change to the OTP version.

josevalim commented 2 years ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart: