search

elixir-protobuf / google-protos

Elixir files generated from Google's protobuf files using protobuf-elixir
MIT License
16 stars 21 forks source link

Add datetime from timestamp #15

Closed yordis closed 2 years ago

whatyouhide commented 2 years ago

Thank you @yordis! As discussed with you on Slack, I don't think this belongs in this library. This library is purely a collection of generated Protobuf Elixir files, so adding logic here increases the scope of the library and sets a precedent that I don't think we should set. Converting a timestamp to a DateTime doesn't add much complexity for users of this library after all.

I’m happy to add such a snippet to an "Examples" or "Things to Know" section in the README.

Thanks again! 💟