Add support for nil value in datetime column

elixir-sqlite / ecto_sqlite3

An Ecto SQLite3 adapter.

https://hexdocs.pm/ecto_sqlite3

MIT License

300 stars 45 forks source link

Add support for nil value in datetime column #136

Closed gshaw closed 11 months ago

gshaw commented 11 months ago

Currently you can read nil values but you can't write nil values to a datetime column. This PR fixes this.

warmwaffles commented 11 months ago

Oh this is silly and should have been caught. Can you add a test in Ecto.Integration.TimestampsTest? Feel free to add a column or table to EctoSQLite3.Integration.Migration.

warmwaffles commented 11 months ago

Awesome! I'll get this cut asap.

gshaw commented 11 months ago

Appreciate it getting merged. Happy to contribute in a small way.