search

elixir-sqlite / ecto_sqlite3

An Ecto SQLite3 adapter.
https://hexdocs.pm/ecto_sqlite3
MIT License
295 stars 44 forks source link

feat: support :time decode #58

Closed sbaildon closed 3 years ago

sbaildon commented 3 years ago

ecto_sqlite3 could not decode fields of type :time—now it can!

I added tests matching the formats the elixir docs presents in Time.from_iso8601/2

edit for posterity: :time is listed as a Ecto.Schema primitive type https://hexdocs.pm/ecto/Ecto.Schema.html#module-primitive-types

warmwaffles commented 3 years ago

This looks okay to me. @kevinlang what do you think?

kevinlang commented 3 years ago

LGTM! interesting - we already had the dumper, just not the loader, for :time