search

elixir-sqlite / exqlite

An SQLite3 driver for Elixir
https://hexdocs.pm/exqlite
MIT License
217 stars 48 forks source link

Added mingw compiler flags #168

Closed dominicletz closed 3 years ago

dominicletz commented 3 years ago

This patch allows building on windows using msys2 when the environment variable MAKE=make

For windows users it's always difficult to get the compilers working right I'm afraid. What do you think @warmwaffles of including for windows users the DLL in the repo like file_system does for that reason? https://github.com/falood/file_system/tree/master/priv and then decide in mix.exs whether to compile: https://github.com/falood/file_system/blob/acfc8a36b1a1bbb2e64e6451173ed03309812b2c/mix.exs#L47

If you're open to that idea I can prepare a pull requests.

warmwaffles commented 3 years ago

I'd prefer not to have binary data shipped with this for as long as possible. One solution I have been batting around is requiring sqlite3 to be installed on the host machine and linkable rather than building it when the library is installed.