elixir-sqlite / exqlite

An SQLite3 driver for Elixir
https://hexdocs.pm/exqlite
MIT License
208 stars 47 forks source link

use size_t to store allocated size #263

Closed ruslandoga closed 11 months ago

ruslandoga commented 11 months ago

fixes #209

warmwaffles commented 11 months ago

I wonder if there is a test we can do to ensure this doesn't happen again. I believe this is the right solution. I think the only way would be to compile in arm64 and run the tests on that architecture. Wonder how hard that is to do with github actions?

ruslandoga commented 11 months ago

I might be wrong but I don't think it's arm64 specific. The pointer was misaligned on x86_64 as well, it's just that C and SQLite didn't care about it and Zig did (maybe because Zig uses SSE instructions in its standard lib, but those require 16-byte alignment...).

warmwaffles commented 11 months ago

Ah