Clean up and improve coverage for sqlite_db_connection.ex. - Githubissues

elixir-sqlite / sqlite_ecto2

Sqlite3 adapter for Ecto 2.2.x

https://hex.pm/packages/sqlite_ecto2

MIT License

120 stars 33 forks source link

Clean up and improve coverage for sqlite_db_connection.ex. #166

Closed scouten closed 7 years ago

sourcelevel-bot[bot] commented 7 years ago

Ebert has finished reviewing this Pull Request and has found:

1 fixed issue! 🎉

You can see more details about this review at https://ebertapp.io/github/scouten/sqlite_ecto2/pulls/166.

coveralls commented 7 years ago

Coverage remained the same at 90.859% when pulling 39fe9ca17abd2909081c95af532b2297492e6f48 on clean-up-sqlite_db_connection into 5af4a32200ae6c9a124ca90f036c5f4741eff966 on master.

coveralls commented 7 years ago

Coverage remained the same at 90.859% when pulling b2ceaae6960e275ee262d04b1595b9bf3280c33a on clean-up-sqlite_db_connection into 5af4a32200ae6c9a124ca90f036c5f4741eff966 on master.

coveralls commented 7 years ago

Coverage remained the same at 90.859% when pulling 9b969d78b1485290b5c496de3681caf640852af5 on clean-up-sqlite_db_connection into 5af4a32200ae6c9a124ca90f036c5f4741eff966 on master.

coveralls commented 7 years ago

Coverage increased (+0.5%) to 91.365% when pulling 2615c8b2a1cf4d3830530a7359a24bc35f26850c on clean-up-sqlite_db_connection into 5af4a32200ae6c9a124ca90f036c5f4741eff966 on master.

coveralls commented 7 years ago

Coverage increased (+1.3%) to 92.135% when pulling ddf12a02a8c5319496af08bfc1eb3ee4fd9e15e1 on clean-up-sqlite_db_connection into 5af4a32200ae6c9a124ca90f036c5f4741eff966 on master.

scouten commented 7 years ago

Closed in favor of #167.