search

elixir-sqlite / sqlite_ecto2

Sqlite3 adapter for Ecto 2.2.x
https://hex.pm/packages/sqlite_ecto2
MIT License
120 stars 33 forks source link

fix(table): Allow renaming column support. #228

Closed jalcine closed 5 years ago

jalcine commented 5 years ago

Support for renaming columns was added in 3.25.0

Release Notes: https://sqlite.org/releaselog/3_25_0.html

Let me know if there's something off with it.

ConnorRigby commented 5 years ago

Ah i seem to have broken CI recently. I'm great with merging, i will just have to Fix CI. Will be sure to merge tomorrow. :+1:

jalcine commented 5 years ago

Thanks! I was so excited to see this in the SQLite docs.

ConnorRigby commented 5 years ago

@jalcine Just ran tests manually, and those two up there fail. Looks like a typo. I suggested changes that should fix it.

jalcine commented 5 years ago

Cool. Looks like no failures but failed to upload coverage information.

jalcine commented 5 years ago

https://circleci.com/gh/elixir-sqlite/sqlite_ecto2/44 failed but it looks like it was only for coverage upload reasons.

jalcine commented 5 years ago

bumping @ConnorRigby

ConnorRigby commented 5 years ago

You are correct. I am not 100% sure what happened but i can get it manually merged in shortly.