Adds support for query timeouts

elixir-sqlite / sqlitex

An Elixir wrapper around esqlite. Allows access to sqlite3 databases.

https://hex.pm/packages/sqlitex

120 stars 34 forks source link

Adds support for query timeouts #78

Closed MichaelBaker closed 5 years ago

MichaelBaker commented 5 years ago

I need the ability to specify per-query timeouts. I've been using my own fork of sqlitex while waiting for the esqlite changes to get merged.

Now that they're merged, it would be nice to get query timeout support into this project so I can use the official releases again.

ConnorRigby commented 5 years ago

I thought this was available currently. I'll look into it if not.

MichaelBaker commented 5 years ago

:+1: I don't believe it is since esqlite only started supporting it like a week ago.

MichaelBaker commented 5 years ago

I've added the requested changes. Let me know what you think.

ConnorRigby commented 5 years ago

@MichaelBaker Sorry to do this, but could you close and reopen this PR? I think my CI config was wrong. It should be fixed, but it doesn't retroactively run CI./

MichaelBaker commented 5 years ago

Yep

coveralls commented 5 years ago

Coverage remained the same at 88.095% when pulling c9984dfe4150af4dfb7d0bb832e33d3ac3bf337c on MichaelBaker:master into f580bfe5b265d3988674d480a533bff8c4d14e9e on elixir-sqlite:master.