elixir-tesla / tesla

The flexible HTTP client library for Elixir, with support for middleware and multiple adapters.
MIT License
2.01k stars 349 forks source link

chore(deps): bump gun from 1.3.3 to 2.0.1 #587

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps gun from 1.3.3 to 2.0.1.

Commits
  • db0655d Gun 2.0.1
  • e763216 Update Cowlib to 2.12.1
  • 33223e7 Update version to 2.0.0
  • a51b1ad Update README
  • e45a925 Update public domain suffix list
  • e3a8fd1 Update copyright lines in preparation for release
  • 096dfdf Update the migration guide for 2.0
  • c8c99b3 Fix intermittent error in stream_info_http test
  • 9c0be06 Selective receive in test to avoid receiving wrong message
  • ffa04a5 Linger a little at the end of a shutdown test connection
  • Additional commits viewable in compare view


Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

yordis commented 1 year ago

closes https://github.com/elixir-tesla/tesla/issues/565

carrascoacd commented 1 year ago

It would be great if we merge this change. I was thinking that the place where adapters are is not very scalable. Let me elaborate. By committing adapters in the same repo and referencing their underlaying libraries as optional you force situations like this:

If we create a different repository and dependency for tesla_gun_adapter and tesla_<other>_adapter we will be able to avoid this situation, since the simple fact of using Tesla doesn't force you to override third dependencies.

It is just an idea, hope it helps!

yordis commented 1 year ago

@carrascoacd This is a well-known problem to me. I will suggest joining https://erlef.org/wg/libs-and-frameworks Slack channel or following Discussions at https://github.com/erlef/libs-and-frameworks/discussions since I am going to be creating a topic related to the issue.

mustela commented 1 year ago

Hello there! is there any plan to merge this? Thanks!

teamon commented 1 year ago

I'd go with {:gun, ">= 1.0"}. Separate adapter packages are a hell to maintain.

egze commented 1 year ago

Is it a flaky test, preventing to get the PR merged?

carrascoacd commented 1 year ago

I think we need to change the function request by headers according to

The function request/5,6 sends the entire request, including the request body, immediately. It is therefore not possible to use gun:data(3) after that. You should provide a content-type header. Gun will set the content-length header automatically.

I left this https://github.com/elixir-tesla/tesla/pull/625 so we can move forward.

yordis commented 1 year ago

@dependabot recreate

yordis commented 1 year ago

https://github.com/dependabot recreate

dependabot[bot] commented 1 year ago

Looks like gun is up-to-date now, so this is no longer needed.