search

elixir-tesla / tesla

The flexible HTTP client library for Elixir, with support for middleware and multiple adapters.
MIT License
2k stars 340 forks source link

Update CI with current Elixir and Erlang/OTP versions #682

Closed nathany-copia closed 3 months ago

nathany-copia commented 3 months ago

I am trying to maintain (in CI) the latest 2 major versions, so Elixir 15+ and OTP 25+; wait 2-3 months and it will be Elixir 16+ and OTP 26+

https://github.com/elixir-tesla/tesla/pull/623#issuecomment-2176886751

This approach runs fewer permutations, so we're not attempting an old version of Elixir on a new version of Erlang. We also can flag the latest version or release candidate as experimental, so that it doesn't block merging, but still reports the failures.

nathany-copia commented 3 months ago

@yordis @teamon What should be done about all the test failures, even on the "supported" Elixir 1.16 build?

nathany-copia commented 3 months ago

@yordis @teamon Everything should be ready for a re-run in CI.

I've marked Elixir 1.16 as experimental until those test failures are fixed, which I think could be a separate pull request.

nathany-copia commented 3 months ago

I think this should be good to merge now.

Then we can follow-up with a PR to get Elixir 1.16 passing and mark it as no longer "experimental" -- if that sounds okay to you?

yordis commented 3 months ago

Yeah, that works! Remember httparrot is the package that needs to be fixed or replace

nathany-copia commented 3 months ago

Yeah, that works! Remember httparrot is the package that needs to be fixed or replace

Opened #684 for that topic. Let's see if it can be fixed.