search

elixir-tesla / tesla

The flexible HTTP client library for Elixir, with support for middleware and multiple adapters.
MIT License
2.01k stars 348 forks source link

Adapter specific options not passed to Finch #714

Closed visciang closed 1 month ago

visciang commented 1 month ago

Version: 1.12.1

App configuration:

config :tesla, :adapter, {Tesla.Adapter.Finch, name: XXX.Finch}

Adapter module:

defmodule XXX.Finch do
  use Tesla

  adapter Tesla.Adapter.Finch, name: __MODULE__, receive_timeout: 40_000
end

Expected:

Finch request (Tesla.Adapter.Finch.request) should be called with [receive_timeout: 40_000, name: XXX.Finch]. Actually it is called with the default options [receive_timeout: 15_000, name: XXX.Finch].

yordis commented 1 month ago

Hey there, I could not reproduce this

config :tesla, :adapter, {Tesla.Adapter.Finch, name: XXX.Finch}

defmodule XXX.Finch do
  use Tesla

  adapter Tesla.Adapter.Finch, name: __MODULE__, receive_timeout: 40_000
end
XXX.Finch.get("http://...")

Please provide some test case proving the brokenness, a video or something that I could replicate this with