Fix for env var precedence and to for File provider required field

elixir-toniq / vapor

Runtime configuration system for Elixir

MIT License

592 stars 36 forks source link

Fix for env var precedence and to for File provider required field #131

Open autodidaddict opened 2 years ago

autodidaddict commented 2 years ago

Fix so the lack of an environment variable subsequent in a pipeline won't cause it to wipe previously established values
Fix so that the File provider now honors the required field (previously ignored, non-required but missing files would cause a crash)

autodidaddict commented 2 years ago

@keathley just checking in to see if this is something that might get looked at?

bsedat commented 2 years ago

As a note for anyone else, an equivalent patch can also be made to the File provider to allow it to supersede env var bindings when an overridden attribute is missing from the file.

brooksmtownsend commented 2 years ago

Hey @keathley / @bgmarx , is this something that's being considered?

mhanberg commented 2 years ago

@autodidaddict do you mind adding a unit test for these two cases? And also maybe an example scenario in the PR description? I think I understand the precedence problem you're describing but it would be great to have an actual example to see.

Thanks!

autodidaddict commented 1 year ago

just checking in since it's been a while and I didn't remember your comment from June. we've been using this fork in production for right around a year now. Do you still want the unit tests, etc @mhanberg ?