elixir-toniq / vapor

Runtime configuration system for Elixir
MIT License
592 stars 36 forks source link

Makes Vapor a behaviour to document the callback injected by __using__ #44

Closed DianaOlympos closed 5 years ago

DianaOlympos commented 5 years ago

This is mostly here to start a conversation.

I was using Vapor for a personal project, and it was quite hard to figure out how to get a value. As the functions are generated, they do not appear in the documentation.

I generated callback definition for them with some basic documentation. It means we have to make the Vapor module a behaviour. I am not sure it is the best architecture, we may want to move that to something a bit more specific like Vapor.Config ?

I use the formatter on save, which deleted some dangling commas. I have no strong opinions on it, so i can add them back if you prefer them back.