search

elixir-tools / credo-language-server

LSP implementation for Credo.
MIT License
96 stars 11 forks source link

feat: report initialization progress #14

Closed wesleimp closed 1 year ago

wesleimp commented 1 year ago

https://user-images.githubusercontent.com/42675056/233760292-84c7b47b-6928-4b04-a778-449626444682.mov

mhanberg commented 1 year ago

image

mhanberg commented 1 year ago

I'll give this a more thorough review when I find time, but my initial thought is that the progress notification should be started/stopped when it begins/ends recalculating the Credo issues.

As it is here, the progress is reporting the time it takes the server to respond to the client, and then then client to notify to the server that it's ready. I'm not sure how useful that information is to the user.

mhanberg commented 1 year ago

Thanks for getting this started!