Closed binarytemple closed 1 year ago
Thank you! I was just thinking about this the other day while on airplane wifi.
Would you mind seeing how to write a test for this?
Also it might be worth switching to vim.fn.jobstart since it can give you the actual exit code. I can't remember if it can be synchronous tho.
As an aside I should probably add a setting to disable automatic release fetching.
I think the bin scripts should default to not including the version in the dep spec if it's not a valid version in the env var.
So it will just use the cached version
Thank you! I was just thinking about this the other day while on airplane wifi.
Me too, oh the joys of flying from Stansted!
Would you mind seeing how to write a test for this?
My first lua code ever, literally copying info from the :help command, might take a while, need a big sleep first.
Also it might be worth switching to vim.fn.jobstart since it can give you the actual exit code. I can't remember if it can be synchronous tho.
Again, complete idiot here, I’ll need to read that up.
As an aside I should probably add a setting to disable automatic release fetching.
So long as it’s graceful, shouldn’t be a big deal, maybe it would be good to cache the info and serve stale version when online?
No worries on the unit test.
Once I get back to a computer I'll test locally and can merge. Can adjust the apis used later.
@binarytemple I made some changes that caches the latest-release result and falls back to it if the call to github fails.
Currently, if you attempt to start elixir-tools when offline, this error is generated:
With this change, if you attempt to start elixir-tools when offline, the following messages will instead be printed to the status line: