search

elixir-tools / elixir-tools.nvim

Neovim plugin for Elixir
MIT License
395 stars 29 forks source link

fix: compile ElixirLS with Elixir v1.16 #188

Closed tiberiuc closed 6 months ago

tiberiuc commented 6 months ago

Release mix task has been deprecated for some time and fails to work with Elixir v1.16. The recommended mix task is release2

mhanberg commented 6 months ago

Can you figure out the failed test?

tiberiuc commented 6 months ago

@mhanberg The first one is because I did not follow the commit message style (sorry for that ). Should I create a new PR with a different commit message ? The second one, I did not test it locally to see if it is working with Elixir v1.13 only tested it with v1.15 and v1.16.

mhanberg commented 6 months ago

You can just change the PR title, it'll re run the lint.

What's the lowest supported Elixir version for Elixir LS?

tiberiuc commented 6 months ago

changed the PR title

The support matrix for ElixirLS is here ElixirLS Support Matrix

tiberiuc commented 6 months ago

@mhanberg I think I found the problem with the tests and found it when installing 0.18.1. The release2 task does not create the release path. Please can you run the tests again?

mhanberg commented 6 months ago

Tests look good. I think I just need to make sure the apple silicon runner in my closet is logged in. My power flipped recently I think