search

elixir-tools / elixir-tools.nvim

Neovim plugin for Elixir
MIT License
403 stars 30 forks source link

Fix umbrella app detection #88

Closed davidelias closed 1 year ago

davidelias commented 1 year ago

This fixes umbrella path detection. Currently, maybe_umbrella_path is always the same as child_or_root_path because of how vim.fs.find works. So this change kind of restores the logic that existed before removing lspconfig dep

Suggestion

It also removes the logic that detects if the umbrella path contains the dir apps. This was because this path could be set to another name in mix. exs with :apps_path, and maybe it is redundant checking for this when we found the mix. exs in a parent dir. But this is a suggestion, and I may be missing something.

mhanberg commented 1 year ago

Can you rebase on main actually?

mhanberg commented 1 year ago

Thanks again! 🤗