elixir-tools / elixir-tools.vscode

Visual Studio Code extension for Elixir
https://marketplace.visualstudio.com/items?itemName=elixir-tools.elixir-tools
Other
88 stars 9 forks source link

Always prompted to install next ls #63

Open css13c opened 11 months ago

css13c commented 11 months ago

The download URL for NextLS is incorrect and so I cannot download it. The /latest path appears to not be valid anymore

mhanberg commented 11 months ago

I am not able to reproduce.

mhanberg commented 11 months ago

can you share your OS and CPU architecture? there is a chance it's mis identifying the binary to download

mtarnovan commented 11 months ago

I'm having the same issue, MacOS Sonoma (14.0) arm64

Edit: managed to download the binary manually, had to rename it, make it executable and run xattr -d com.apple.quarantine nextls, so @mhanberg I think you may be right that OS or arch is not identified correctly, leading to a wrong download URL.

ketupia commented 11 months ago

Me also. I'm using VSCode on Windows 11.

image

Here's the about data from VSCode

Version: 1.83.1 (user setup)
Commit: f1b07bd25dfad64b0167beb15359ae573aecd2cc
Date: 2023-10-10T23:48:05.904Z
Electron: 25.8.4
ElectronBuildId: 24154031
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.22621

The Extension Host log shows:

2023-10-26 11:59:18.891 [error] Activating extension elixir-tools.elixir-tools failed due to an error:
2023-10-26 11:59:18.891 [error] Error: Download failed (https://github.com/elixir-tools/next-ls/releases/latest/download/next_ls_windows_amd64, status=404)
    at c:\Users\ketup\.vscode\extensions\elixir-tools.elixir-tools-0.11.0\dist\extension.js:2:432487
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at l.force (c:\Users\ketup\.vscode\extensions\elixir-tools.elixir-tools-0.11.0\dist\extension.js:2:432228)
    at c:\Users\ketup\.vscode\extensions\elixir-tools.elixir-tools-0.11.0\dist\extension.js:2:431445
    at e.activate (c:\Users\ketup\.vscode\extensions\elixir-tools.elixir-tools-0.11.0\dist\extension.js:2:430807)
    at v.n (c:\Users\ketup\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:125:6205)
    at v.m (c:\Users\ketup\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:125:6168)
    at v.l (c:\Users\ketup\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:125:5625)
mhanberg commented 11 months ago

@ketupia That is definitely a bug in the extension, the url should have a ".exe" on the end of it.

But I'll note I don't think Next LS works on windows yet (most folks have been using WSL so far) but I now have a computer to test it on so I hope to get it working soon.

@css13c @mtarnovan are you able to see the same 404 log? If yes can you share it so I can see what URL it's trying to hit