Code action putting the underscore wrongly

elixir-tools / next-ls

The language server for Elixir that just works. Ready for early adopters!

https://www.elixir-tools.dev/next-ls

MIT License

701 stars 40 forks source link

Code action putting the underscore wrongly #433

Open andrepaes opened 6 months ago

andrepaes commented 6 months ago

When i have a unused var then i trigger the code action to put the underscore to stop compiler warning then the underscore is placed on the beginning of the line instead of in front of the var. this is my elixir and erlang version: erlang 24.3.4.1 elixir 1.13.4-otp-24 I'm running on a Linux manjaro kernel version 6.5.3-1-MANJARO and cpu intel 14700K

NJichev commented 6 months ago

The code action uses the line:column from the elixir extension's diagnostic. I assume that the older version of elixir just reports the column as 0. @mhanberg maybe this will be fixed with the vendored version of elixir once this is released?

mhanberg commented 6 months ago

@NJichev this sounds likely

NJichev commented 6 months ago

Hey 👋 The latest release bundles together an Elixir version, can you try updating and seeing whether the issue persists. Thanks in advance

andrepaes commented 6 months ago

Hey, the project i'm working on is using otp 24 so i'm not able to get the new release working here