search

elixir-tools / spitfire

Error tolerant parser for Elixir
https://www.elixir-tools.dev
MIT License
75 stars 7 forks source link

fix: parse struct add 1 column #8

Closed lucacervello closed 9 months ago

lucacervello commented 9 months ago

Hi Mitch,

I saw your tweet https://twitter.com/mitchhanberg/status/1755631616452403660 and I give it a try.

In my environment, running tests gives me 15 failed tests. I don't know if that is supposed to happen.

Anyways, this PR addresses 5 tests that were failing, so we are now down to 10 failed tests.

I hope PRs are welcomed at this stage of the project 😄

lukaszsamson commented 9 months ago

Be warned that this column offset is due to a bug that was recently fixed https://github.com/elixir-lang/elixir/commit/fd4e6b530c0e010712b06909c89820b08e49c238

mhanberg commented 9 months ago

Yes, please use the elixir ref that is in the mise.toml file.

I forgot to update the tool-versions file to have the same.

lucacervello commented 9 months ago

Thank you, it was odd the tests were failing, I created a new PR with the .tools-versions update https://github.com/elixir-tools/spitfire/pull/9.

I'll close this, thank you 😄