Closed visciang closed 7 years ago
+1 on cleaning up the unused INCLUDE and LIB variables
I'm not sure on the indentation change to make the file less readable. That seems like an overly restrictive coding standard to fix issues with Makefile recipes and the code in question is not a recipe. Even the GNU Makefile documentation has indentation in their example of a conditional (the final one that's not in a recipe uses 2-space indentation even): https://www.gnu.org/software/make/manual/make.html#Conditional-Example. If this change did something besides lower readability (like increase portability, performance, etc.), then I'd be for it. Otherwise, I'd prefer it left as is.
OK! I rollback the indentation changes.
Thanks! @electricshaman - this looks good to me.
Awesome! Thanks, @visciang!