britton-jb commented 2 years ago

Esbuild has become the new standard for Phoenix asset management, and so this adds a note about how to use Wallaby with it.

mhanberg commented 2 years ago

Can you add a link to the esbuild hex package?

codecov-commenter commented 2 years ago

Codecov Report

Merging #675 (2881ba6) into main (5e02d94) will decrease coverage by 3.31%. The diff coverage is n/a.

:exclamation: Current head 2881ba6 differs from pull request most recent head eef7015. Consider uploading reports for the commit eef7015 to get more accurate results

@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
- Coverage   88.04%   84.72%   -3.32%     
==========================================
  Files          24       24              
  Lines         995      995              
==========================================
- Hits          876      843      -33     
- Misses        119      152      +33

Flag	Coverage Δ
IntegrationTest	`80.96% <ø> (-0.24%)`	:arrow_down:
UnitTest	`41.80% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
lib/wallaby/query.ex	`81.53% <0.00%> (-16.93%)`	:arrow_down:
lib/wallaby/driver/log_store.ex	`72.72% <0.00%> (-9.10%)`	:arrow_down:
lib/wallaby/feature.ex	`66.66% <0.00%> (-7.41%)`	:arrow_down:
lib/wallaby.ex	`92.85% <0.00%> (-7.15%)`	:arrow_down:
lib/wallaby/browser.ex	`87.72% <0.00%> (-6.82%)`	:arrow_down:
lib/wallaby/chrome.ex	`93.51% <0.00%> (-2.78%)`	:arrow_down:
lib/wallaby/selenium.ex	`17.07% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 330025c...eef7015. Read the comment docs.

elixir-wallaby / wallaby

Adds esbuild config info to the README #675

Codecov Report