search

elixir-wallaby / wallaby

Concurrent browser tests for your Elixir web apps.
https://twitter.com/elixir_wallaby
MIT License
1.68k stars 198 forks source link

Adds a note about the on_mount hook for async LiveView testing #677

Closed britton-jb closed 2 years ago

britton-jb commented 2 years ago

Part 2 for testing LiveView with Wallaby async. Part 1

mhanberg commented 2 years ago

One last thought, sorry.

What do you think about adding the current live view version to the docs you added?

Just so if it changes and becomes out of date, it will hopefully be fairly obvious to check the love view changelog.

britton-jb commented 2 years ago

That’s a great call, I’ll add that. Thanks.

codecov-commenter commented 2 years ago

Codecov Report

Merging #677 (53cbbd7) into main (5e02d94) will decrease coverage by 3.31%. The diff coverage is n/a.

:exclamation: Current head 53cbbd7 differs from pull request most recent head f389501. Consider uploading reports for the commit f389501 to get more accurate results

@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
- Coverage   88.04%   84.72%   -3.32%     
==========================================
  Files          24       24              
  Lines         995      995              
==========================================
- Hits          876      843      -33     
- Misses        119      152      +33
Flag Coverage Δ
IntegrationTest 80.96% <ø> (-0.24%) :arrow_down:
UnitTest 41.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/wallaby/query.ex 81.53% <0.00%> (-16.93%) :arrow_down:
lib/wallaby/driver/log_store.ex 72.72% <0.00%> (-9.10%) :arrow_down:
lib/wallaby/feature.ex 66.66% <0.00%> (-7.41%) :arrow_down:
lib/wallaby.ex 92.85% <0.00%> (-7.15%) :arrow_down:
lib/wallaby/browser.ex 87.72% <0.00%> (-6.82%) :arrow_down:
lib/wallaby/chrome.ex 93.51% <0.00%> (-2.78%) :arrow_down:
lib/wallaby/selenium.ex 17.07% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e8a7b81...f389501. Read the comment docs.