search

elixir-wallaby / wallaby

Concurrent browser tests for your Elixir web apps.
https://twitter.com/elixir_wallaby
MIT License
1.68k stars 198 forks source link

Start chromedriver with PartitionSupervisor #692

Closed mhanberg closed 2 years ago

mhanberg commented 2 years ago

This will open as many chromedrivers you have as cores, and partition access to them based on the test pid. This effectively acts as a "pool" of chromedrivers without needing logic to check them in and out of the pool.

It just acts as if there is a single chromedriver and it seems to just work.

TODO

Add the Elixir-lang license to the partition supervisor file.

Related to #365

@AndroidOatmeal do you mind testing out this branch?

mhanberg commented 2 years ago

@AndroidOatmeal pinging you again in case the last notification got lost.

AndroidOatmeal commented 2 years ago

@mhanberg Thank you! It's been a busy week so far, but I'll test this out in the next couple days

mhanberg commented 2 years ago

@AndroidOatmeal no worries, I really appreciate it!

AndroidOatmeal commented 2 years ago

@mhanberg I spent some time testing this out today and I'm happy to say it seems to work great! I can't tell you how excited I feel lol. Thanks again for the assist here.

I've been running our acceptance test suite over and over with this wallaby branch trying to flush out any hiding issues. Strangely, once I got the usual (RuntimeError) Wallaby had an internal issue, but it only happened with a seemingly random pair of tests, and the rest of the suite finished successfully. Even after 10 runs of our suite, I haven't been able to reproduce this again, but I'll let you know if this or other issues pop up.

mhanberg commented 2 years ago

Thanks for testing this out!

I just returned from a work trip so I'll hopefully get this tidied up and merged in the next few days.

I'll probably publish a release candidate and have more people try it out for a little bit then I'll publish the actual release.

mhanberg commented 2 years ago

I contracted covid during the aforementioned work trip, so I haven't gotten around to this 😅. I hope to get an RC release out in the next couple days.

AndroidOatmeal commented 2 years ago

@mhanberg Sorry to hear about the covid — it really whooped my ass too. Hope you're feeling better!