elixir-wallaby / wallaby

Concurrent browser tests for your Elixir web apps.
https://twitter.com/elixir_wallaby
MIT License
1.68k stars 198 forks source link

Allow to skip chromedriver-chrome version match check #697

Closed michallepicki closed 2 years ago

michallepicki commented 2 years ago

After https://github.com/elixir-wallaby/wallaby/pull/688 got merged, Wallaby no longer works with chromium on Linux (I think it will not work with a custom installation path on Windows either).

One solution would be to allow the chromedirver-chrome version match check to be skipped.

mhanberg commented 2 years ago

Are you configuring the chrome binary path or is this with chrome driver finding it on its own?

michallepicki commented 2 years ago

Are you configuring the chrome binary path or is this with chrome driver finding it on its own?

Chromedriver is finding chromium on its own

mhanberg commented 2 years ago

I'll try to see if we can make it work with chromium, but if it can't, then adding an option to disable is probably required.

mhanberg commented 2 years ago

Released in v0.30.1