search

elixir-wallaby / wallaby

Concurrent browser tests for your Elixir web apps.
https://twitter.com/elixir_wallaby
MIT License
1.65k stars 196 forks source link

`run_command.sh` improvements #751

Open sirikid opened 10 months ago

sirikid commented 10 months ago

https://github.com/elixir-wallaby/wallaby/blob/ef4451583a0af9997de097f3d8da0f9e6ffb8efc/priv/run_command.sh#L12-L13

Should not there be $1 and $2?

mhanberg commented 10 months ago

I thought that as well a while ago, but after testing it, it seemed to not work the same (or, better), so I left it how it is.

A measurable improvement would be a welcome contribution!