search

elixir-wallaby / wallaby

Concurrent browser tests for your Elixir web apps.
https://twitter.com/elixir_wallaby
MIT License
1.65k stars 196 forks source link

Minor thing: change wording of docs --> browser / users are not the same. #760

Open maikelthedev opened 7 months ago

maikelthedev commented 7 months ago

Elixir and Erlang/OTP versions

not needed

Operating system

not needed

Browser

not needed

Driver

not needed

Correct Configuration

Current behavior

In here

image

it should say:

Because Wallaby manages multiple browser windows for you, its possible to test several users interacting with a page simultaneously.

or

Because Wallaby manages multiple users for you, its possible to test several users interacting with a page simultaneously.

Not just "browsers" because otherwise it leads us to think you're talking about testing with e.g.: Firefox.

Expected behavior

above

Test Code & HTML

not needed

Demonstration Project

not needed

mhanberg commented 7 months ago

You can actually open a session in two different browsers (chrome and Firefox) and control them in the same test.

But adding the word "windows" in there seems alright. 👍

maikelthedev commented 7 months ago

You can actually open a session in two different browsers (chrome and Firefox) and control them in the same test.

Good to know.

But adding the word "windows" in there seems alright. 👍

I'm glad you agree.