elixir-web / weber

[WiP] Web framework for Elixir inspired by Rails [#WeberMVC at freenode]
http://elixir-web.github.io/weber/
MIT License
370 stars 33 forks source link

Ecto not actually a dependency #194

Closed tobyhede closed 10 years ago

tobyhede commented 10 years ago

Adding Ecto to my app resulted in:

module Ecto.Repo is not loaded and could not be found

Adding the declaration to mix.exs

{ :ecto, github: "elixir-lang/ecto" }

Resolves the issue. Not sure what the correct behaviour should be? Should Ecto be added to weber mix deps?

0xAX commented 10 years ago

Hello @tobyhede,

there is no specific code for databases and ecto generally in weber, so i decided to not include ecto to the weber deps list, user can add it if need.

tobyhede commented 10 years ago

Cool. The readme suggests that ecto is a dependency.

I was thinking of adding some basic ecto support to weber-contrib for ease of use?

On 3 May 2014 03:33, 0xAX notifications@github.com wrote:

Hello @tobyhede https://github.com/tobyhede,

there is no specific code for databases and ecto generally in weber, so i decided to not include ecto to the weber deps list, user can add it if need.

— Reply to this email directly or view it on GitHubhttps://github.com/elixir-web/weber/issues/194#issuecomment-42057157 .

rcdilorenzo commented 10 years ago

@tobyhede, separating common libraries is still often useful since people will sometimes use one without the other and will therefore have less code simply floating in the project that is unused. It also mean we don't have to worry about which version of Ecto to include.