search

elixir-web / weber

[WiP] Web framework for Elixir inspired by Rails [#WeberMVC at freenode]
http://elixir-web.github.io/weber/
MIT License
370 stars 33 forks source link

Fix Compatibility with Elixir 0.14.2 #203

Closed rcdilorenzo closed 10 years ago

rcdilorenzo commented 10 years ago

...waiting to merge until elixir-web/weber-contrib#3 fixes elixir-web/weber-contrib#2.

rcdilorenzo commented 10 years ago

elixir-web/weber-contrib#3 is now finished, but still waiting for https://github.com/guedes/exjson/pull/28 to be merged before weber is full compatible with 0.14.1

rcdilorenzo commented 10 years ago

According to Travis-CI, there are some other build issues. I'll work on some of these. It also looks like exjson is only an issue when we are using elixir-master for 0.14.2-dev.

adamkittelson commented 10 years ago

Not sure how to do these updates and have them gel with your PR, but a couple other things that need to be taken care of for 0.14.2 are any instances of *.Behavior need the .Behavior stripped, e.g. GenServer.Behavior -> GenServer

Any instances of Plug.Adapters.Cowboy.Conn need to be changed to Plug.Conn and the plug dependency in mix.exs should be updated to {:plug, "~> 0.5.1" }

I submitted a PR to exjson (https://github.com/guedes/exjson/pull/31) for 0.14.2 compatibility. That project hasn't accepted a PR on 2 months though so weber may be better off changing to another json project like https://hex.pm/packages/jazz

rcdilorenzo commented 10 years ago

Yes, @adamkittelson, we may need to switch to another json reader since exjson seems to have paused development. I'll try and talk this over with @0xAX.