search

elixir-webrtc / ex_webrtc

An Elixir implementation of the W3C WebRTC API
Apache License 2.0
269 stars 8 forks source link

Respond to incoming NACK #100

Closed mickel8 closed 2 months ago

codecov[bot] commented 2 months ago

Codecov Report

Merging #100 (49b3e31) into master (945615b) will decrease coverage by 0.75%. The diff coverage is 69.73%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #100 +/- ## ========================================== - Coverage 87.88% 87.13% -0.75% ========================================== Files 32 33 +1 Lines 1576 1625 +49 ========================================== + Hits 1385 1416 +31 - Misses 191 209 +18 ``` | [Files](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/100?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) | Coverage Δ | | |---|---|---| | [lib/ex\_webrtc/rtp\_sender/nack\_responder.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/100?src=pr&el=tree&filepath=lib%2Fex_webrtc%2Frtp_sender%2Fnack_responder.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9ydHBfc2VuZGVyL25hY2tfcmVzcG9uZGVyLmV4) | `100.00% <100.00%> (ø)` | | | [lib/ex\_webrtc/rtp\_sender.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/100?src=pr&el=tree&filepath=lib%2Fex_webrtc%2Frtp_sender.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9ydHBfc2VuZGVyLmV4) | `92.10% <76.92%> (-7.90%)` | :arrow_down: | | [lib/ex\_webrtc/rtp\_transceiver.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/100?src=pr&el=tree&filepath=lib%2Fex_webrtc%2Frtp_transceiver.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9ydHBfdHJhbnNjZWl2ZXIuZXg=) | `89.80% <85.71%> (-1.17%)` | :arrow_down: | | [lib/ex\_webrtc/peer\_connection.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/100?src=pr&el=tree&filepath=lib%2Fex_webrtc%2Fpeer_connection.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9wZWVyX2Nvbm5lY3Rpb24uZXg=) | `82.55% <45.16%> (-1.29%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/100/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/100?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/100?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). Last update [945615b...49b3e31](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/100?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc).
LVala commented 2 months ago

Closing this PR in favour of a new one as Github does not allow changing the owner of a PR.