Closed mickel8 closed 2 months ago
Merging #102 (a45b08a) into master (37db947) will increase coverage by
0.06%
. The diff coverage is95.00%
.:exclamation: Current head a45b08a differs from pull request most recent head 4f726fc. Consider uploading reports for the commit 4f726fc to get more accurate results
Besides fixes listed below, this PR also update deps and adjusts code to the newest ex_ice.
Fixes:
bundle-only
attribute, see here. This is used by Firefox when PC is configured withbundlePolicy: "maxBundle"
maxBundle
policy (the only one we support), candidates are only included in the first m-line, see here. This seems to be true even if the first m-line is stopped in subsequent offers, at least until ICE restart, which I left untouched i.e. we always include candidates in the first mlineQuestionable:
in
maxBundle
policy, all mlines but the first one should havebundle-only
attribute added, and port in the m-section set to 0, see here. However, there are differences between JSEP RFC, BUNDLE RFC, and browser implementations (see RFC 8829. sec. 1.3 and because of that, we still don't use neither port 0 nor bundle-only attributedepending on the
bundle-policy
, browsers may send candidates for every m-section, only for the first m-section, or for every type of m-section. There is a question, which candidates we should add to the ICE agent on the answerer side (as we only have one ICE stream and one ICE component) - all of them or only those from the first m-section. Looking at RFC 8829, sec. 5.11:so we could take only those candidates that belong to the first m-section as other ICE components on the offerer side should be closed anyway. However, because current solution seems to work, I would go back to this question once we notice any problems.
depending on the
rtcpMuxPolicy
browsers may generate candidates only for one ICE component (RTP) or for two ICE components (RTP and RTCP) doubling the number of ICE candidates. There is the same question as in the point above, and we do exactly the same thing i.e. we add all candidates regardless of their ICE components.