search

elixir-webrtc / ex_webrtc

An Elixir implementation of the W3C WebRTC API
Apache License 2.0
269 stars 8 forks source link

Fix simulcast issues #121

Closed LVala closed 1 week ago

LVala commented 1 week ago

This PR:

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.20%. Comparing base (e6c8dad) to head (41ff049).

:exclamation: Current head 41ff049 differs from pull request most recent head f5eaf38

Please upload reports for the commit f5eaf38 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #121 +/- ## ========================================== - Coverage 87.50% 87.20% -0.31% ========================================== Files 34 34 Lines 1721 1727 +6 ========================================== Hits 1506 1506 - Misses 215 221 +6 ``` | [Files](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/121?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) | Coverage Δ | | |---|---|---| | [lib/ex\_webrtc/media\_stream\_track.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/121?src=pr&el=tree&filepath=lib%2Fex_webrtc%2Fmedia_stream_track.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9tZWRpYV9zdHJlYW1fdHJhY2suZXg=) | `100.00% <100.00%> (ø)` | | | [lib/ex\_webrtc/rtp\_receiver.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/121?src=pr&el=tree&filepath=lib%2Fex_webrtc%2Frtp_receiver.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9ydHBfcmVjZWl2ZXIuZXg=) | `70.49% <100.00%> (-9.84%)` | :arrow_down: | | [lib/ex\_webrtc/rtp\_transceiver.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/121?src=pr&el=tree&filepath=lib%2Fex_webrtc%2Frtp_transceiver.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9ydHBfdHJhbnNjZWl2ZXIuZXg=) | `91.46% <100.00%> (-0.06%)` | :arrow_down: | | [lib/ex\_webrtc/sdp\_utils.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/121?src=pr&el=tree&filepath=lib%2Fex_webrtc%2Fsdp_utils.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9zZHBfdXRpbHMuZXg=) | `92.41% <100.00%> (+0.32%)` | :arrow_up: | | [lib/ex\_webrtc/peer\_connection.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/121?src=pr&el=tree&filepath=lib%2Fex_webrtc%2Fpeer_connection.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9wZWVyX2Nvbm5lY3Rpb24uZXg=) | `82.30% <0.00%> (+0.27%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/121/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/121?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/121?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). Last update [e6c8dad...f5eaf38](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/121?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc).