search

elixir-webrtc / ex_webrtc

An Elixir implementation of the W3C WebRTC API
Apache License 2.0
270 stars 8 forks source link

Fix `Demuxer` initialization based on SDP #130

Closed LVala closed 3 days ago

LVala commented 3 days ago

Close #129

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.16%. Comparing base (b55c7f6) to head (600bc95).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #130 +/- ## ========================================== - Coverage 87.20% 87.16% -0.05% ========================================== Files 36 36 Lines 1853 1854 +1 ========================================== Hits 1616 1616 - Misses 237 238 +1 ``` | [Files](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/130?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) | Coverage Δ | | |---|---|---| | [lib/ex\_webrtc/sdp\_utils.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/130?src=pr&el=tree&filepath=lib%2Fex_webrtc%2Fsdp_utils.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9zZHBfdXRpbHMuZXg=) | `91.78% <80.00%> (-0.64%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/130?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/130?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). Last update [b55c7f6...600bc95](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/130?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc).