search

elixir-webrtc / ex_webrtc

An Elixir implementation of the W3C WebRTC API
Apache License 2.0
270 stars 8 forks source link

Move ICETransport initialization to PeerConnection #27

Closed mickel8 closed 7 months ago

codecov[bot] commented 7 months ago

Codecov Report

Merging #27 (689b4b3) into master (7aa4685) will decrease coverage by 0.39%. The diff coverage is 96.15%.

:exclamation: Current head 689b4b3 differs from pull request most recent head d138b25. Consider uploading reports for the commit d138b25 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #27 +/- ## ========================================== - Coverage 79.69% 79.31% -0.39% ========================================== Files 11 11 Lines 522 522 ========================================== - Hits 416 414 -2 - Misses 106 108 +2 ``` | [Files](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) | Coverage Δ | | |---|---|---| | [lib/ex\_webrtc/ice\_transport.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9pY2VfdHJhbnNwb3J0LmV4) | `77.77% <100.00%> (+2.77%)` | :arrow_up: | | [lib/ex\_webrtc/peer\_connection.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9wZWVyX2Nvbm5lY3Rpb24uZXg=) | `73.36% <100.00%> (+0.37%)` | :arrow_up: | | [lib/ex\_webrtc/dtls\_transport.ex](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc#diff-bGliL2V4X3dlYnJ0Yy9kdGxzX3RyYW5zcG9ydC5leA==) | `75.00% <94.44%> (-3.27%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/27?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/27?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). Last update [7aa4685...d138b25](https://app.codecov.io/gh/elixir-webrtc/ex_webrtc/pull/27?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-webrtc).